Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typescript-Node] Mark deprecated endpoints #19770

Merged
merged 9 commits into from
Oct 3, 2024
Merged

[Typescript-Node] Mark deprecated endpoints #19770

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
80e9aa8
Add @deprecated tag for deprecated operations
gcatanese Oct 3, 2024
545be33
Add test helper to verify a given line
gcatanese Oct 3, 2024
32593b1
Add test to verify deprecated method
gcatanese Oct 3, 2024
1894382
Regenerate samples
gcatanese Oct 3, 2024
2453686
Delete tmp files after test
gcatanese Oct 3, 2024
297ed4f
Remove assertFileContains on specific line
gcatanese Oct 3, 2024
2e41247
Update modules/openapi-generator/src/main/resources/typescript-node/a…
gcatanese Oct 3, 2024
e4029a8
Correct indentation
gcatanese Oct 3, 2024
d68656a
Regenerate samples
gcatanese Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/openapi-generator/src/main/resources/typescript-node/api-single.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export class {{classname}} {
{{/allParams}}
{{#isDeprecated}}
*
* @deprecated
* @deprecated
Copy link
Contributor

@joscha joscha Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you had tabs. If you use spaces to indent it, it should work. My suggestion removed the tab.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated
* @deprecated

This should work, it's tricky in the webinterface :)

{{/isDeprecated}}
*/
public async {{nickname}} ({{#allParams}}{{paramName}}{{^required}}?{{/required}}: {{{dataType}}}, {{/allParams}}options: {headers: {[name: string]: string}} = {headers: {}}) : Promise<{ response: http.IncomingMessage; {{#returnType}}body: {{{.}}}; {{/returnType}}{{^returnType}}body?: any; {{/returnType}} }> {
Expand Down
Loading