Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erlang server validation bugfixes and capability extensions #19750

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

NelsonVides
Copy link
Contributor

Three things:

  • First of all, fix a bug where exclusiveMinimum and exclusiveMaximum were considered integers, when they are in fact booleans.
  • Add support for validating that strings of format byte are indeed base64 encoded and return them parsed.
  • Likewise for strings of format date-time.

Other changes are related to general performance optimisations and code quality.

Question, @wing328, I'm not sure to understand how documentation for the capabilities of the generators work, and I'm afraid they might be falling behind with all the recent changes, can you share with me some directions on this? I'd work on that on a follow-up PR though, just to keep this one focused.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    • That's myself :)

@NelsonVides NelsonVides changed the title Erlang server Erlang server validation bugfixes and capability extensions Oct 2, 2024
@wing328
Copy link
Member

wing328 commented Oct 3, 2024

Question, @wing328, I'm not sure to understand how documentation for the capabilities of the generators work, and I'm afraid they might be falling behind with all the recent changes, can you share with me some directions on this? I'd work on that on a follow-up PR though, just to keep this one focused.

are you referring to updating https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/ErlangServerCodegen.java#L50 ?

@wing328
Copy link
Member

wing328 commented Oct 3, 2024

thanks for the PR

fyi @tsloughter (2017/11) @jfacorro (2018/10) @robertoaloi (2018/10) @NelsonVides (2024/09)

@wing328 wing328 merged commit 83f6d59 into OpenAPITools:master Oct 3, 2024
19 checks passed
@wing328 wing328 added this to the 7.9.0 milestone Oct 3, 2024
@NelsonVides NelsonVides deleted the erlang-server branch October 6, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants