Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-pistache-server] Generated code fails to build with x86_64-linux-gnu-g++-13 #19684

Conversation

winkler-pixop
Copy link
Contributor

@winkler-pixop winkler-pixop commented Sep 26, 2024

This PR fixes #19683

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Mentions

@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

Copy link
Contributor

@muttleyxd muttleyxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but did you regenerate the samples? I don't see changes in Helpers.h, only in mustache source file

@winkler-pixop
Copy link
Contributor Author

Looks good, but did you regenerate the samples? I don't see changes in Helpers.h, only in mustache source file

Ah... that is what it meant. I did not commit those samples until now.
Thanks for pointing out.

The samples should be updated now, to reflect the change to the Mustache template.

@winkler-pixop
Copy link
Contributor Author

Hi, @muttleyxd

Have you had a chance to look this over again?

@wing328 wing328 added this to the 7.9.0 milestone Oct 1, 2024
@wing328 wing328 merged commit 2551689 into OpenAPITools:master Oct 1, 2024
15 checks passed
@wing328
Copy link
Member

wing328 commented Oct 1, 2024

thanks for the PR, which has been merged

@winkler-pixop winkler-pixop deleted the bugfix/fixes-CPP-pistache-server-19683 branch October 1, 2024 06:09
@winkler-pixop
Copy link
Contributor Author

Thanks a ton, Wing328.

@wing328 wing328 changed the title Fix #19683 : Generated code fails to build with x86_64-linux-gnu-g++-13 [cpp-pistache-server] Generated code fails to build with x86_64-linux-gnu-g++-13 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [CPP] [pistache-server] Generated code fails to build with x86_64-linux-gnu-g++-13
3 participants