Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp][generichost] Fix local var #19642

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

devhl-labs
Copy link
Contributor

@devhl-labs devhl-labs commented Sep 22, 2024

Partial fix for #19626 Potentially breaking for anyone who has a custom on error implementation.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@homer-simpson
Copy link

Why do you write a “LocalVar” after every local variable? That violates every code convention I know from C# or C++. Sorry, but this makes it unnecessarily difficult to read code and makes it very confusing...

@devhl-labs
Copy link
Contributor Author

It is a standard in this repo to avoid conflicts with generated variables.

@wing328 wing328 merged commit 9300a68 into OpenAPITools:master Sep 29, 2024
50 checks passed
@devhl-labs devhl-labs deleted the 19626-fix-local-var branch September 29, 2024 15:17
@wing328 wing328 added this to the 7.9.0 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants