-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swift5] Fix Xcode 16 compilation crash with Extensions.swift generation #19564
[swift5] Fix Xcode 16 compilation crash with Extensions.swift generation #19564
Conversation
This is important to get merged |
@lilidotshi Great, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR
This seems to break alamofire generation using |
Hi @tcollins590 can you elaborate on the problem you are having? |
@4brunu I noticed that Xcode 16's release notes say that they have officially fixed this issue, do you see any reason to revert this PR back to its original? |
If reverting this PR fixes the issue and works with Xcode 16, for me we can revert this. |
I tried it out in the morning. The old code does not work with Xcode 16.
|
And what is the issue with the new code? |
@4brunu I'll dig deeper into the errors I was running into and report back |
Also, what version are you using @tcollins590. @4brunu has a release with this patch even come out yet? |
No, not yet |
@lilidotshi I was using the branch that this PR merged into. The issue came up with using |
This PR aims to address #19459 with the solution provided by @borsosbe.
Mentioning swift tech commitee: @dydus0x14 @4brunu @jgavris @ehyche @Edubits @jaz-ah for visibility into the issue.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)