Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swift5] Fix Xcode 16 compilation crash with Extensions.swift generation #19564

Merged

Conversation

lilidotshi
Copy link
Contributor

@lilidotshi lilidotshi commented Sep 10, 2024

This PR aims to address #19459 with the solution provided by @borsosbe.

Mentioning swift tech commitee: @dydus0x14 @4brunu @jgavris @ehyche @Edubits @jaz-ah for visibility into the issue.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@aehlke
Copy link

aehlke commented Sep 10, 2024

This is important to get merged

@lilidotshi lilidotshi changed the title Fix Xcode 16 compilation crash with Extensions.swift generation [swift5] Fix Xcode 16 compilation crash with Extensions.swift generation Sep 11, 2024
@borsosbe
Copy link

@lilidotshi Great, thanks!

Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR

@4brunu 4brunu merged commit 0e763b0 into OpenAPITools:master Sep 11, 2024
34 checks passed
@lilidotshi lilidotshi deleted the lshi/fix-xcode-16-nsdecimal-generation branch September 11, 2024 14:17
@tcollins590
Copy link

This seems to break alamofire generation using --library alamofire

@4brunu
Copy link
Contributor

4brunu commented Sep 17, 2024

Hi @tcollins590 can you elaborate on the problem you are having?

@lilidotshi
Copy link
Contributor Author

@4brunu I noticed that Xcode 16's release notes say that they have officially fixed this issue, do you see any reason to revert this PR back to its original?

@4brunu
Copy link
Contributor

4brunu commented Sep 17, 2024

If reverting this PR fixes the issue and works with Xcode 16, for me we can revert this.
Can someone try the old code with Xcode 16 to confirm that reverting this PR fixes the issue?

@r3econ
Copy link

r3econ commented Sep 17, 2024 via email

@4brunu
Copy link
Contributor

4brunu commented Sep 17, 2024

And what is the issue with the new code?
Can someone give more details on that?

@tcollins590
Copy link

@4brunu I'll dig deeper into the errors I was running into and report back

@lilidotshi
Copy link
Contributor Author

Also, what version are you using @tcollins590. @4brunu has a release with this patch even come out yet?

@4brunu
Copy link
Contributor

4brunu commented Sep 17, 2024

No, not yet

@tcollins590
Copy link

@lilidotshi I was using the branch that this PR merged into. The issue came up with using --library alamofire I'll run it again in a bit.

@wing328 wing328 added this to the 7.9.0 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants