Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kotlin-spring][server] fix spring boot configuration conflict #19515

Merged

Conversation

medliii
Copy link
Contributor

@medliii medliii commented Sep 3, 2024

I generated two folders with two different specs, which caused a conflict with the autowiring of the DefaultExceptionHandler class. To resolve this, I set different configuration names.

Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanDefinitionStoreException: Failed to parse configuration class [xdc.core.api.XdcCoreApiApplication]; nested exception is org.springframework.context.annotation.ConflictingBeanDefinitionException: Annotation-specified bean name 'defaultExceptionHandler' for bean class [xdc.external.apis.DefaultExceptionHandler] conflicts with existing, non-compatible bean definition of same name and class [xdc.tools.apis.DefaultExceptionHandler]

@dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@medliii medliii changed the title fix kotlin spring boot configuration conflict [kotlin-spring] fix spring boot configuration conflict Sep 3, 2024
@medliii medliii changed the title [kotlin-spring] fix spring boot configuration conflict [kotlin-spring][server] fix spring boot configuration conflict Sep 3, 2024
@medliii medliii force-pushed the fix-kotlin-configuration-conflict branch from 758d110 to 3bb4972 Compare September 5, 2024 07:19
@medliii
Copy link
Contributor Author

medliii commented Sep 5, 2024

rebase master

@wing328
Copy link
Member

wing328 commented Sep 9, 2024

thanks for the PR

i don't think this will break existing use cases from the first glance so let's give it a try

in case it does, we will need to add an option for rollback

@wing328 wing328 merged commit 0026e15 into OpenAPITools:master Sep 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants