-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript-fetch] Add option to generate validation attributes of model properties #19448
[typescript-fetch] Add option to generate validation attributes of model properties #19448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution, looks good!
can you please change the template according to my comment and then we can merge this?
@@ -157,4 +157,39 @@ export function {{classname}}ToJSON(value?: {{#hasReadOnly}}Omit<{{classname}}, | |||
{{^hasVars}} | |||
return value; | |||
{{/hasVars}} | |||
} | |||
}{{#validationAttributes}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}{{#validationAttributes}} | |
} | |
{{#validationAttributes}} |
uniqueItems?: boolean | ||
} | ||
} = { {{#vars}}{{#hasValidation}} | ||
{{name}}: { {{#maxLength}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can put the stuff on new lines, like
{{#maxLength}}maxLength: {{maxLength}},{{/maxLength}}
{{#minLength}}minLength: {{minLength}},{{/minLength}}
...
this makes the template nicer to read
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
1f74b0f
to
ee28ca6
Compare
ee28ca6
to
e0d251c
Compare
@macjohnny I changed the formatting of the template. |
Adds a new option to generate validation attributes of model properties. This allows the use of these attributes for schema validation.
The following attributes are exposed via a lookup table of the model property:
The following attributes are exposed via an object when model has additional properties:
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)