Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Check if the given input is a container (Array or Map) when validating enum values #19316

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

vcutrona
Copy link
Contributor

@vcutrona vcutrona commented Aug 7, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

PR description

This PR solves issue #19274 by checking the input type on enum validators. The current version does not consider Dict (i.e., Map) as a possible value. The PR includes an addition check (isContainer and isMap) to verify if all values of the given Map are from the given enum.

cc @cbornet @tomplus @krjakbrjak @fa0311 @multani

@vcutrona vcutrona changed the title Check if the given input is a container (Array or Map) when validating enum values [python] Check if the given input is a container (Array or Map) when validating enum values Aug 7, 2024
@wing328
Copy link
Member

wing328 commented Aug 14, 2024

@vcutrona thanks for the PR. can you please review the test failure when you've time?

@vcutrona
Copy link
Contributor Author

@wing328 I can't reproduce the same issue in my local environment (I started the petstore Docker container and ran all the tests successfully).
Also, I triggered the same workflow on my fork, and no checks failed (I first executed the workflow without updating the samples, then I ran again the workflow after updating the samples).
I believe the failed checks are not related to this PR (I can see many other PRs failing the same checks).

@wing328
Copy link
Member

wing328 commented Oct 10, 2024

all python tests passed via #19829

let's give this fix a try

thanks for the PR

@wing328 wing328 merged commit 45fa438 into OpenAPITools:master Oct 10, 2024
20 of 23 checks passed
@wing328 wing328 added this to the 7.10.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants