Java libraries validation-api may use javax imports but dependency always uses jakarta namespace #19171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18332 replaced instances of
{{javaPackage}}.validation
withjakarta.validation
because all generated poms under Java/libraries usejakarta.validation:jakarta.validation-api:3.0.2
(which uses jakarta package namespace).However a couple of moustache templates were missed out, so if
useJakartaEe
flag was disabled, some code would still requirejavax.validation.*
while some would requirejakarta.validation.*
- this PR fixes that by aligning with the package included in the generated pom.Note that this issue only affects
jakarta.validation-api
and notjakarta.annotation-api
. Annotation API uses different versions in the pom depending on theuserJakartaEe
flag, e.g. https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/Java/libraries/rest-assured/pom.mustache#L360PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)