Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Fix object serialization for multipart requests #18140

Merged
merged 2 commits into from
Mar 19, 2024
Merged

[Python] Fix object serialization for multipart requests #18140

merged 2 commits into from
Mar 19, 2024

Conversation

Poolmann
Copy link
Contributor

Dumps the contents of dicts into a json string for multipart requests.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Poolmann Poolmann mentioned this pull request Mar 18, 2024
Closed
6 tasks
@Poolmann Poolmann changed the title Fix object serialization multipart python [Python] Fix object serialization for multipart requests Mar 18, 2024
fa0311 added a commit to fa0311/openapi-generator that referenced this pull request Mar 19, 2024
@fa0311
[Python] add test object serialization for multipart requests OpenAPI…
aa3bfce 
…Tools#18140
@fa0311 fa0311 mentioned this pull request Mar 19, 2024
Merged
5 tasks
fa0311
fa0311 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@fa0311 fa0311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@wing328 wing328 added this to the 7.5.0 milestone Mar 19, 2024
fa0311 added a commit to fa0311/openapi-generator that referenced this pull request Mar 19, 2024
@fa0311
[Python] add test object serialization for multipart requests OpenAPI…
d84b3ab 
…Tools#18140
@wing328 wing328 merged commit b7ea139 into OpenAPITools:master Mar 19, 2024
34 checks passed
@fa0311 fa0311 mentioned this pull request Mar 21, 2024
Merged
5 tasks
zapodot pushed a commit to zapodot/openapi-generator that referenced this pull request Mar 21, 2024
@Poolmann @zapodot
[Python] Fix object serialization for multipart requests (OpenAPITool…
48fb23d 
…s#18140)

* Fix multipart object serialization

* Update samples
wing328 pushed a commit that referenced this pull request Mar 24, 2024
@fa0311
[Python] Add test object serialization for multipart requests (#18156)
9acd620 
* [Python] add test object serialization for multipart requests #18140

* [python] update samples

* [python] update samples
roryschadler added a commit to roryschadler/openapi-generator that referenced this pull request Aug 5, 2024
@roryschadler
fix: object serialization for multipart requests
261fbf9 
This PR is essentially
<OpenAPITools#18140> but for
the asyncio client.
@roryschadler roryschadler mentioned this pull request Aug 5, 2024
Merged
5 tasks
roryschadler added a commit to roryschadler/openapi-generator that referenced this pull request Aug 7, 2024
@roryschadler
fix: object serialization for multipart requests
1c5ac78 
This PR is essentially
<OpenAPITools#18140> but for
the asyncio client.
roryschadler added a commit to roryschadler/openapi-generator that referenced this pull request Aug 8, 2024
@roryschadler
fix: object serialization for multipart requests
0c37a90 
This PR is essentially
<OpenAPITools#18140> but for
the asyncio client.
roryschadler added a commit to roryschadler/openapi-generator that referenced this pull request Aug 23, 2024
@roryschadler
fix: object serialization for multipart requests
0d66133 
This PR is essentially
<OpenAPITools#18140> but for
the asyncio client.
roryschadler added a commit to roryschadler/openapi-generator that referenced this pull request Aug 27, 2024
@roryschadler
feat: object, int serialization for multipart reqs
bbfd186 
Extends previous commits (and OpenAPITools#18140) to cover the python-pydantic-v1
client as well.
wing328 pushed a commit that referenced this pull request Sep 9, 2024
@roryschadler
fix(python,asyncio): multipart form data serialization (#19302)
8171648 
* fix: object serialization for multipart requests

This PR is essentially
<#18140> but for
the asyncio client.

* fix: int serialization for multipart requests

urllib3 handles serializing ints in post params (ref 1), while asyncio
explicitly does not (ref 2).

ref 1: <https://github.com/urllib3/urllib3/blob/9316764e90aea8d193cd8f03b0caccdf02af3ba0/src/urllib3/filepost.py#L75-L76>
ref 2: <aio-libs/aiohttp#920>

* test: new fake multipart endpoint with files and body

* test: regression test for stringified body params

* fix: mypy tweak

* fix: FILES regeneration

* feat: object, int serialization for multipart reqs

Extends previous commits (and #18140) to cover the python-pydantic-v1
client as well.

* fix: use async with in test

* test: regression test for pydantic-v1-aiohttp

* test: add regression test to pydantic-v1

Also brings the second test in line with the first, patching
`urllib3.PoolManager.urlopen`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fa0311 fa0311 fa0311 approved these changes

Assignees
No one assigned
Labels
Client: Python Issue: Bug
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Poolmann @fa0311 @wing328