Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java][native] Fix missing imports when using list validation #17857

Merged

Conversation

steven-sheehy
Copy link
Contributor

Fixes #17485 which was a regression in 7.2.0 after #17165 was merged. That change did not add the necessary imports to the generated API when bean validation was enabled and the schema contained an array that had item level validation.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg @wing328

@wing328
Copy link
Member

wing328 commented Feb 14, 2024

thanks for the fix, which looks good to me.

if no further feedback/question from anyone, i'll merge it tomorrow

@wing328 wing328 merged commit 8cd34ac into OpenAPITools:master Feb 15, 2024
14 checks passed
@steven-sheehy steven-sheehy deleted the 17485-fix-native-validation branch February 15, 2024 05:49
kota65535 pushed a commit to kota65535/openapi-generator that referenced this pull request Feb 23, 2024
@wing328 wing328 added this to the 7.4.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] V7.2.0 Breaks Schema Validation Imports
2 participants