Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] added handling for boolean content type #17020

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

OliverTetzTT
Copy link
Contributor

I added handling of boolean types in text/plain request bodies.

Example YAML:

openapi: 3.0.0
info:
  title: Test Boolean
  version: 1.0.0
servers:
  - url: /
paths:
  /test:
    get:
      operationId: test
      requestBody:
        content:
          text/plain:
            schema:
              type: boolean
        required: true
      responses:
        "200":
          description: Success
        default:
          description: Unexpected Error

Before adding the section in the rest.py the request could not be created.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

@multani
Copy link
Contributor

multani commented Nov 9, 2023

Run the following to build the project and update samples:

./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh

@OliverTetzTT can you re-run these steps to regenerate the files?

@OliverTetzTT
Copy link
Contributor Author

Run the following to build the project and update samples:

./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh

@OliverTetzTT can you re-run these steps to regenerate the files?

@multani I just committed the new samples.

Thanks for the remark. Did not need this for my last PR, so skipped it again this time... sorry. I will do this for future PRs.

@wing328
Copy link
Member

wing328 commented Nov 14, 2023

lgtm. thanks for the PR.

@wing328 wing328 merged commit d1b148a into OpenAPITools:master Nov 14, 2023
31 checks passed
jpuerto pushed a commit to movementsciences/openapi-generator that referenced this pull request Nov 14, 2023
* added handling for boolean content type

* adapted addition to newer version of template

* [python] updated samples
lwj5 pushed a commit to lwj5/openapi-generator that referenced this pull request Dec 5, 2023
* added handling for boolean content type

* adapted addition to newer version of template

* [python] updated samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants