-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add socks5 proxy support for OpenAPI generated python client #16918
Merged
wing328
merged 7 commits into
OpenAPITools:master
from
rolf-moz:support-socks5-proxy-v7x
Nov 14, 2023
Merged
Add socks5 proxy support for OpenAPI generated python client #16918
wing328
merged 7 commits into
OpenAPITools:master
from
rolf-moz:support-socks5-proxy-v7x
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rolf-moz could you rebase or merge with main? There has been a large change merged recently that also changed part of the code you want to change. |
@multani I resolved conflicts with the base branch, and cleaned up the proxy support code a bit. |
lgtm. thanks for the PR. |
jpuerto
pushed a commit
to movementsciences/openapi-generator
that referenced
this pull request
Nov 14, 2023
…Tools#16918) * add socks5 proxy support (requires additional import) * updated examples * build samples. updated to support pydantic python option * rename sock to socks for correct protocol name * add proxy headers for pydantic * fixed param changes from conflict resolution
lwj5
pushed a commit
to lwj5/openapi-generator
that referenced
this pull request
Dec 5, 2023
…Tools#16918) * add socks5 proxy support (requires additional import) * updated examples * build samples. updated to support pydantic python option * rename sock to socks for correct protocol name * add proxy headers for pydantic * fixed param changes from conflict resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Socks proxies for python.
This feature was requested: #16568
(note this is a resubmission as my original PR to the 8.x branch was a bad branch)
urlib3 already supports socks with the 'urlib3[socks]' variant or by installing PySocks.
Proxy types mirror what Urlib3 supports: "sock5" "socks5h" "socks4" "socks4a"
I would like advice on how to add tests for this.
@cbornet @tomplus @krjakbrjak @fa0311 @multani
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)