[Java] [Kotlin] ignore unsupported schemes instead of throwing exception #15817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiffmaelite
commented
Jun 12, 2023
| @@ -72,11 +72,16 @@ class ApiClient( | |||
| authNames: Array<String> | |||
| ) : this(baseUrl, okHttpClientBuilder) { | |||
| authNames.forEach { authName -> | |||
| val auth = when (authName) { | |||
| "petstore_auth" -> OAuth(OAuthFlow.implicit, "http://petstore.swagger.io/api/oauth/dialog", "", "write:pets, read:pets")"api_key" -> ApiKeyAuth("header", "api_key") | |||
There was a problem hiding this comment.
I think that this was also incorrect kotlin code due to the lack of line break before "api_key"
But I wonder why compilation and/or tests did not fail when this was introduced
There was a problem hiding this comment.
agreed. the CI should have caught the issue. let me take a look tomorrow or later this week
There was a problem hiding this comment.
the code still compiles in the latest master so the CI is doing the "right" thing
There was a problem hiding this comment.
i cannot come up with a way off the top of my head to catch this issue easily moving forward. will merge this for the time being and later add a test (hopefully)
tiffmaelite
deleted the
fix/fix_no-exception-unsupported-scheme-java-kotlin
branch
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert changes of #14876 and replace them with a new implementation which fixes the underlying issue while avoiding changing behavior by introducing potentially unexpected exception-throwing situations. As a result, the previous behavior of silently ignoring unsupported schemes is kept.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)Java: @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
Kotlin: @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)