Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GO] Fix value formatting in url with slices #15581

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

darkrift
Copy link
Contributor

@darkrift darkrift commented May 19, 2023

This is to fix the client generation problem related to #14798 where url value ends up being reflect.Value+value instead of their real value.

@antihax @grokify @kemokemo @jirikuncar @ph4r5h4d @lwj5

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@darkrift darkrift changed the title [GO] Fix value formatting in url with slices [BUG][GO] Fix value formatting in url with slices May 20, 2023
@darkrift darkrift changed the title [BUG][GO] Fix value formatting in url with slices [GO] Fix value formatting in url with slices May 20, 2023
@darkrift
Copy link
Contributor Author

darkrift commented May 23, 2023

I am not sure why node3 is failing. The message relates to angular but I have not touched that code section, unless it's a side effect from the go code refresh

@darkrift
Copy link
Contributor Author

darkrift commented Jun 5, 2023

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)

Could I get a review for this and add this to the next releases ? Is there anything missing in the PR ?

I don't think the node3 build failures is directly related to this change, but I may be wrong. Could you point me in the right direction if it is linked to my changes ?

@wing328
Copy link
Member

wing328 commented Jun 15, 2023

thanks for the PR. will try to review this weekend and get it merged

@ppbaena
Copy link

ppbaena commented Jun 30, 2023

Hi @wing328,
Is there any update here? It looks like everything is almost ready to review and merge. It would be great to use the upstream solution for this.
Please, let me know if I can help some way.
Thanks!

@wing328 wing328 added this to the 7.0.0 milestone Jul 3, 2023
@wing328
Copy link
Member

wing328 commented Jul 3, 2023

circleci tests passed via https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/24493/workflows/7418e43a-ff72-4ed8-965a-a1d2d11bba05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants