Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] fix use of isBasic condition #15520

Merged
merged 1 commit into from
May 20, 2023

Conversation

tiffmaelite
Copy link
Contributor

@tiffmaelite tiffmaelite commented May 16, 2023

Follow-up of #15220 but for PHP

isBasic is true for HTTP bearer auth method and HTTP signature method, not only HTTP basic auth method; it should not be used when we want to apply code changes in the context of HTTP basic auth only!

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@tiffmaelite tiffmaelite changed the title [PHP] fix use of isBasicBasic and isBasicBearer conditions [PHP] fix use of isBasic condition May 16, 2023
@tiffmaelite tiffmaelite force-pushed the fix/fix_use_isBasic_php branch from 8918099 to f09e74c Compare May 16, 2023 08:05
@wing328 wing328 added this to the 7.0.0 milestone May 20, 2023
@wing328 wing328 merged commit 7eeb7f6 into OpenAPITools:master May 20, 2023
@tiffmaelite tiffmaelite deleted the fix/fix_use_isBasic_php branch May 22, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants