Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Go Github workflow #15200

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Improve Go Github workflow #15200

merged 5 commits into from
Apr 12, 2023

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Apr 12, 2023

Improve Go Github workflow by installing missing dependencies.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

FYI @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)

@lwj5
Copy link
Contributor

lwj5 commented Apr 12, 2023

name: Samples Go 

on:
  push:
    paths:
      - 'samples/server/petstore/go-echo-server/**'
      - 'samples/server/petstore/go-api-server/**'
      - 'samples/server/petstore/go-chi-server/**'
  pull_request:
    paths:
      - 'samples/server/petstore/go-echo-server/**'
      - 'samples/server/petstore/go-api-server/**'
      - 'samples/server/petstore/go-chi-server/**'

jobs:
  build:
    name: Build Go 
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
      matrix:
        sample:
          - samples/server/petstore/go-echo-server/
          - samples/server/petstore/go-api-server/
          - samples/server/petstore/go-chi-server/
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-go@v3
        with:
          go-version: "stable"
      - run: go version
      - name: Run test
        working-directory: ${{ matrix.sample }}
        run: go test -mod=mod -v

could you try this file

@lwj5
Copy link
Contributor

lwj5 commented Apr 12, 2023

we could add a cache in a future PR if you like, to prevent it from downloading the deps everytime

@wing328
Copy link
Member Author

wing328 commented Apr 12, 2023

all go server tests passed

@wing328 wing328 merged commit c0322b1 into 7.0.x Apr 12, 2023
@wing328 wing328 deleted the improve-go-workflow branch April 12, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants