Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-ue4] Series of fixes for cpp-ue4 #15068

Merged
merged 4 commits into from
Apr 1, 2023

Conversation

Kahncode
Copy link
Contributor

Hello,

After recently updating openapi-generator for our project I noticed some regressions in past pull requests as well as missing features.
Additions are detailed in the commits but:

  • Fixed compilation warnings
  • Fixed compilation error on APIs using files in http forms, which was a big breaking change and honestly i'm surprised nobody reported it before
  • Added support for enums as url parameters
  • Cosmetic improvements to the generated code

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Kahncode
Copy link
Contributor Author

@wing328 Please note that I have not updated the samples

@wing328 wing328 modified the milestones: 6.5.0, 6.6.0 Apr 1, 2023
@wing328 wing328 merged commit 033b946 into OpenAPITools:master Apr 1, 2023
@wing328
Copy link
Member

wing328 commented Apr 1, 2023

samples updated via 3d7c173

@Kahncode
Copy link
Contributor Author

Kahncode commented Apr 1, 2023

@leith-bartrich As this was merged, could you please confirm that your use-case is still functional? I want to make sure we didn't break it for your usage. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants