Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Crystal] Allow double colons in model name #13736

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

cyangle
Copy link
Contributor

@cyangle cyangle commented Oct 19, 2022

Allows double colons in model names. So that cli option --type-mappings=AnyType=JSON::Any works out of the box.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cyangle
Copy link
Contributor Author

cyangle commented Oct 19, 2022

@wing328 I mainly added method sanitizeModelName and use it in method toModelName.

I also added a few basic tests and formatted the code.

@cyangle
Copy link
Contributor Author

cyangle commented Oct 19, 2022

It seems like there are test failures in the unit tests job but github actions reported success.

@wing328
Copy link
Member

wing328 commented Oct 19, 2022

LGTM

@wing328 wing328 merged commit b2e8a15 into OpenAPITools:master Oct 19, 2022
@wing328 wing328 added this to the 6.2.1 milestone Oct 19, 2022
@cyangle cyangle deleted the crystal_sanitize_model_name branch October 19, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants