Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [CPP-UE4] Fix codegen for nested container types #12747

Merged

Conversation

madrazzl3
Copy link
Contributor

Fixed code generation for nested container type (list of lists / map of lists) for UE4.

@wing328 @Kahncode

Testcase for testing:
https://gist.github.com/madrazzl3/b2d9ab436b16fa82151816d31f73468b

Fix #12746

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Kahncode
Copy link
Contributor

Hello @madrazzl3. Thanks for the fix, it looks quite good. Could you share the difference in the generated code?

@madrazzl3
Copy link
Contributor Author

madrazzl3 commented Jul 1, 2022

> #12746

Hi, there is one from issue ticket:

Before:

TOptional<TMap<FString, TArray>> PetsMapExample;

After:

TOptional<TMap<FString, TArray<Pet>>> PetsMapExample;

Similar for List type:

Before:

TOptional<TArray<TArray>> PetsArrayExample;

After:
TOptional<TArray<TArray<Pet>>> PetsArrayExample;

@Kahncode
Copy link
Contributor

Kahncode commented Jul 1, 2022

Great! Looks good to me.

@wing328 wing328 merged commit b372f64 into OpenAPITools:master Jul 2, 2022
@wing328 wing328 added this to the 6.0.1 milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][CPP-UE4] Invalid codegen for nested container types
3 participants