[typescript-fetch] Support error handler in middleware #12716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) |
macjohnny
reviewed
Jun 28, 2022
| } | ||
| } | ||
| if (!response) { | ||
| throw new FetchError(e, 'Interceptors did not provide an alternative response'); |
There was a problem hiding this comment.
How about “The request failed and the interceptors did not return an alternative response?
There was a problem hiding this comment.
Sure, changed
| @@ -166,7 +166,25 @@ export class BaseAPI { | |||
| }) || fetchParams; | |||
| } | |||
| } | |||
| let response = await (this.configuration.fetchApi || fetch)(fetchParams.url, fetchParams.init); | |||
| let response = null; | |||
There was a problem hiding this comment.
No worries, done
| }) || response; | ||
| } | ||
| } | ||
| if (!response) { |
There was a problem hiding this comment.
Suggested change
| if (!response) { | |
| if (response !== undefined) { |
orange-buffalo
force-pushed
the
error-handler-in-middleware
branch
from
586f0bc to
4c7b870
Compare
macjohnny
approved these changes
Jun 29, 2022
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status Quo
typescript-fetchprovides support for two types of interceptors: to pre-process the request and post-process the response. However, there is one more case which is not handled - network or similar error when response is not received.PR suggestion
This PR suggests an additional interceptor hook
onErrorthat covers the missing piece. It is called in case of exception during request processing and allows to, for instance, re-try the request, replace it with alternative route, etc.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.0.1) (patch release),6.1.x(breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)