Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] No @NotNull annotation for readOnly (required) attributes #10820

Conversation

daniel-sc
Copy link
Contributor

fixes #5026

This duplicates #5960 (which was stale because of missing feedback/updates from creator).

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@daniel-sc
Copy link
Contributor Author

Hi @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch
Could anyone please review this?
I'm happy to update the PR if some things don't match expectations.

@feech
Copy link
Contributor

feech commented Nov 25, 2021

138 files have changed! and mostly of them just formatting.
I am not a reviewer but you made everything to slow down the process.

@daniel-sc
Copy link
Contributor Author

@feech this is because of the required re-generation of docs (./bin/utils/export_docs_generators.sh) - together with the (known) issue that newline can not be controlled well with mustache..

(if you ask me, this shows why the general best practice is not to version control generated content - but of course others might have more insights for this specific repository!)

@daniel-sc
Copy link
Contributor Author

Hi @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch
Anyone up for a review and/or feedback?
I'd be happy to resolve the merge conflicts that appeared in the meantime, but only if there is some reasonable expectation on this getting merged ;-)

@wing328
Copy link
Member

wing328 commented Feb 14, 2022

@daniel-sc thanks for the PR. Can you please resolve the merge conflicts and PM me via Slack?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@daniel-sc daniel-sc force-pushed the 5026-no-notnull-annotations-for-read-only branch 2 times, most recently from d7263c3 to f0fa5ba Compare February 15, 2022 14:54
@daniel-sc daniel-sc force-pushed the 5026-no-notnull-annotations-for-read-only branch 2 times, most recently from 2698fbb to f0d1dc4 Compare February 16, 2022 07:25
@wing328 wing328 added this to the 6.0.0 milestone Feb 16, 2022
@wing328 wing328 merged commit 035736f into OpenAPITools:master Feb 16, 2022
@daniel-sc daniel-sc deleted the 5026-no-notnull-annotations-for-read-only branch February 16, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spring-java] required readonly attribute generate not null field
3 participants