-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQ][typescript-angular] Angular 9 providedIn support #6432
Comments
@UnleashSpirit would you like to implement this? |
Waow hmm yeah I can try. |
great
exactly, here are some starting points: Lines 99 to 101 in b87c927
Lines 46 to 53 in b87c927
|
@UnleashSpirit did you progress on this one ? |
Hi, unfortunately not yet :( |
Adding new option, providedIn, for generator typescript-angular Keep providedInRoot for backward compatibility but mark as deprecated for Angular 9+ fix: OpenAPITools#6432
* feat: add providedIn for Angular 9+ Adding new option, providedIn, for generator typescript-angular Keep providedInRoot for backward compatibility but mark as deprecated for Angular 9+ fix: #6432 * doc: providedIn infos about providedIn Mark providedInRoot as deprecated * doc: run generate-samples for typescript using typescript-angular-v9-provided-in-any.yaml * refactor: runned ensure-up-to-date locally * refactor: api.module.mustache rely on providedIn too * doc: re-generate samples
Hello,
Angular 9 brings new level for @Injectable, 'any' and 'platform'
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Removing the 'providedInRoot' option as boolean and gives a new one.
Something like 'providedIn' with all the choices :
May be with keeping default as root ?
And may be a ApiModule.forPlatform() ? (don't even know if it makes sense)
Additional context
I face that 'issue', which is not a real one for now more an improvement, during Angular Elements creation (WebComponent).
In my case I have a service provided un 'platform' level which also depend on generated service from openapi v3. But a 'platform' service can't use a root level service (null injector)
In any case I think that supporting the new levels of Angular 9 Injectable would be appreciate
The text was updated successfully, but these errors were encountered: