This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Implement Jaeger Support For Frontend #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzcankirmemis
force-pushed
the
jaeger
branch
from
d41a6cd to
5b0aa8b
Compare
oguzcankirmemis
force-pushed
the
jaeger
branch
from
ace761c to
2632aaf
Compare
… to work with docker
…nction for jaeger instruments
arkocal
previously approved these changes
Jan 18, 2019
|
Oh, please sign your commits (or at least final commit) (git commit -s -S) (see |
|
@arkocal ok, autocheck removed. |
|
@arkocal @wagmarcel ok, I have signed the last commit, you can merge it now. |
…ew tags to root span for searching Signed-off-by: ogz <[email protected]>
arkocal
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, all middlewares, all routes, and all postgres calls should be traced and the spans should be sent to jaeger-client.
Please test with jaeger ui, and report if something (like tags) needs to be changed, before it gets approved.