Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure run_udf returns a DryRunDataCube if required #323 #324

Merged
merged 4 commits into from
Nov 8, 2024
Merged

ensure run_udf returns a DryRunDataCube if required #323 #324

merged 4 commits into from
Nov 8, 2024

Conversation

JeroenVerstraelen
Copy link
Contributor

No description provided.

@JeroenVerstraelen JeroenVerstraelen self-assigned this Nov 7, 2024
@JeroenVerstraelen JeroenVerstraelen linked an issue Nov 7, 2024 that may be closed by this pull request
dry_run of run_udf process only produces JSONResult #323
Closed
soxofaan
soxofaan reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks even simpler than we discussed earlier, so that's good.

just some unit test notes

tests/test_views_execute.py Outdated Show resolved Hide resolved
tests/test_views_execute.py Outdated Show resolved Hide resolved
soxofaan
soxofaan approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge (if tests pass)

but I would also add a changelog entry (and maybe version bump)

@JeroenVerstraelen JeroenVerstraelen merged commit 8f6729b into master Nov 8, 2024
@JeroenVerstraelen JeroenVerstraelen deleted the 323-dry_run-of-run_udf-process-only-produces-jsonresult branch November 8, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan soxofaan approved these changes

Assignees

@JeroenVerstraelen JeroenVerstraelen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dry_run of run_udf process only produces JSONResult
2 participants
@JeroenVerstraelen @soxofaan