Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default batch job log level #294

Closed
soxofaan opened this issue Jun 24, 2024 · 4 comments
Closed

Default batch job log level #294

soxofaan opened this issue Jun 24, 2024 · 4 comments

Comments

@soxofaan
Copy link
Member

@blueprint.route("/jobs/<job_id>/logs", methods=["GET"])
@auth_handler.requires_bearer_auth
def get_job_logs(job_id, user: User):
offset = request.args.get("offset")
level = request.args.get("level")

openEO spec specifies INFO level as default, but we leave it undefined, causing DEBUG logs to be included by default, which slows down working with logs, e.g. in the web editor

@soxofaan
Copy link
Member Author

soxofaan commented Jun 24, 2024

openEO spec specifies INFO level as default

correction: the default level when fetching batch job logs is DEBUG, but that is not clear from current docs. Also see Open-EO/openeo-api@6ea99c3

@soxofaan
Copy link
Member Author

soxofaan commented Jun 24, 2024

On the other hand, the default minimum log level when creating a jobs (min_log_level_default) is INFO in the openEO spec, while we probably log everything unnecessarily

@jdries
Copy link
Contributor

jdries commented Sep 30, 2024

Not sure if that is correct: when explicitly requesting debug logging in our batch jobs, a lot more is logged.
I think that we correctly provide 'INFO' logging for the moment, with some exceptions where debug logging is explicitly included.

@soxofaan
Copy link
Member Author

indeed this issue has been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants