Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue #678 support shapely in load collection spatial extent #682

Closed
wants to merge 18 commits into from
Closed

issue #678 support shapely in load collection spatial extent #682

wants to merge 18 commits into from

Conversation

ElienVandermaesenVITO
Copy link
Contributor

issue #678

soxofaan
soxofaan reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay

already looks great.

openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
tests/rest/datacube/test_datacube.py Show resolved Hide resolved
@soxofaan
Copy link
Member

Also to be added is a bullet in changelog (under "Added" section)

soxofaan
soxofaan reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some additional notes

CHANGELOG.md Outdated Show resolved Hide resolved
openeo/rest/connection.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
soxofaan
soxofaan reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more notes :)

openeo/rest/connection.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Show resolved Hide resolved
openeo/rest/datacube.py Show resolved Hide resolved
@soxofaan
Copy link
Member

soxofaan commented Jan 7, 2025

can you merge latest master branch in this feature branch and resolve the conflict on CHANGELOG.md?

@soxofaan soxofaan mentioned this pull request Jan 8, 2025
Open
soxofaan
soxofaan reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some final cosmetic tweaks

openeo/rest/connection.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/datacube.py Outdated Show resolved Hide resolved
openeo/rest/connection.py Outdated Show resolved Hide resolved
@soxofaan soxofaan mentioned this pull request Jan 13, 2025
Open
@soxofaan soxofaan mentioned this pull request Jan 16, 2025
Open
@soxofaan
Merge remote-tracking branch 'origin/master' into issue678-load_colle…
d83b3c8 
…ction-support-shapely-geometry-input
@soxofaan
Issue #678/#682 further finetuning
ac11868 
- doc and typing tweaks
- push more functionality to _get_geometry_argument
- add support in load_stac as well
@soxofaan
Copy link
Member

FYI: with ac11868 I pushed some more finetuning to this branch

@soxofaan soxofaan self-assigned this Jan 17, 2025
soxofaan added a commit that referenced this pull request Jan 17, 2025
@soxofaan
Issue #678/#682 further finetuning
f95728d 
- doc and typing tweaks
- push more functionality to _get_geometry_argument
- add support in load_stac as well
soxofaan added a commit that referenced this pull request Jan 17, 2025
@soxofaan
Issue #678/#682 more test coverage of spatial_extent handling
4a45519
soxofaan added a commit that referenced this pull request Jan 17, 2025
@soxofaan
Issue #678/#682 more tests for load_stac spatial_extent handling
dda8bcb
soxofaan added a commit that referenced this pull request Jan 17, 2025
@soxofaan
Issue #678/#682 finetune TestDataCube tests
e1fa369
@soxofaan
Copy link
Member

(rebased and) merged in 0794610

thanks!

@soxofaan soxofaan closed this Jan 17, 2025
This was referenced Jan 17, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soxofaan soxofaan Awaiting requested review from soxofaan

Assignees

@soxofaan soxofaan

@ElienVandermaesenVITO ElienVandermaesenVITO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElienVandermaesenVITO @soxofaan