Jupyter integration: UI components for data discovery #170
Conversation
|
The code itself looks fine. I'll have a look at failing tests. |
|
@m-mohr the problem seems to be that some methods return a List[dict], not a dict, for instance: list_processes, list_collections |
|
@jdries I've added a VisualList. Multi inheritance doesn't seem to be the best entry point for a Python noob, but it seems to work in Jupyter... ;-) Is there a way to run the tests locally? I couldn't find details in the docs. |
to run the test you need the dev dependencies (from https://github.com/Open-EO/openeo-python-client/blob/master/.travis.yml): and then you should be able to run the test suite with: We indeed should document this somewhere better |
|
@soxofaan Thanks. Tests succeed now and I've created an issue to document the test procedure. So from my side this can be reviewed and merged. We'll likely need to update the script URL again in some days/weeks, but that's only until we left beta/rc version numbers in vue-components again. |
|
I've implemented a workaround. This should be ready to go (but it seems TravisCI is acting up - I guess we need to migrate openEO CI at some point to GH Actions...) |
openeo/internal/jupyter.py
Outdated
| # These classes are proxies to visualize openEO responses nicely in Jupyter | ||
| # To show the actual list or dict in Jupyter, use repr() or print() | ||
|
|
||
| SCRIPT_URL = 'https://cdn.jsdelivr.net/npm/@openeo/[email protected]/assets/openeo.js' |
There was a problem hiding this comment.
maybe add a todo note here
TODO: get this script url dynamically e.g. from a https://editor.openeo.org/ quert or from a local config file, with hardcoded fallback?
There was a problem hiding this comment.
I'm not sure. We could add it to a config file, but we can't and shouldn't get it through other means dynamically. The implementation is bound to the specific version and once we have a stable version 2.0.0 (in one or two weeks) it will be SCRIPT_URL = 'https://cdn.jsdelivr.net/npm/@openeo/vue-components@2/assets/openeo.js', which will cover always the latest version of the 2.x branch and then we won't change it any time soon again as 3.x would be breaking anyway.
There was a problem hiding this comment.
We can keep this PR open until we have a 2.0.0 release.
There was a problem hiding this comment.
Or merge now? This will not be released immediately anyway, but it will make it available to other people testing on master?
There was a problem hiding this comment.
@jdries Sure, I'm fine with that. Just released another RC for vue-components so that all recent changes are in. Feel free to merge at any time.
There was a problem hiding this comment.
This will not be released immediately anyway
@jdries But four hours later 😂 👍
m-mohr
force-pushed
the
vue-components
branch
from
9a4c5c4 to
d8ea1cb
Compare
This is the PR to show beautiful UI elements in Jupyter environments. (marketing mode off)
Currently, it supports Capabilties, Collections, Processes, File Formats, Service Types and UDF Runtimes. I'll likely try to implement Logs (
GET .../logs) next.This is still a bit experimental because I've re-implemented the technical basis to hopefully avoid issues between React and Vue, but has another issue out of my scope.
I'd appreciate a review from you guys as my Python programming skilly is still beginner-level. Please let me know anything that you think would be worth changing. Why does the build fail? I can't access your Jenkins...
Example:
