Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for pre-0.4 API? #72

Closed
soxofaan opened this issue Aug 8, 2019 · 4 comments
Closed

Drop support for pre-0.4 API? #72

soxofaan opened this issue Aug 8, 2019 · 4 comments

Comments

@soxofaan
Copy link
Member

soxofaan commented Aug 8, 2019

Open question: is it necessary to keep supporting 0.3-style API in the python client? I have not really an idea whether there are actual users that use the python client with 0.3-only backends.

There are quite some differences between the 0.3 and 0.4 versions of the API (how process graphs work, terminology, etc), and supporting both in the python client code makes things a bit tedious and hard to maintain.

It would benefit speed of development and code quality if we could get rid of all the 0.3-related code and implementation details.

@m-mohr
Copy link
Member

m-mohr commented Aug 19, 2019

None of the other clients (except the openEO Hub) support multiple versions at the moment. For now, I'd say users of the 0.3 API could simply use the latest version available that supports 0.3. (I don't think there are many, maybe only the openeo-result-validation-engine?) Of course that means there must be a release for it, which is available for all other clients except Python, I think.

So action items could be:

  1. Release a version that supports 0.3 (as 0.0.5?)
  2. Drop 0.3 support
  3. Align with 0.4 and do another release (as 0.1.0?)

Related #68

@jdries
Copy link
Collaborator

jdries commented Aug 20, 2019

Releases of the python client do exist:
https://artifactory.vgt.vito.be/webapp/#/artifacts/browse/simple/General/python-openeo/openeo/0.0.5
also for older versions:
https://artifactory.vgt.vito.be/webapp/#/artifacts/browse/simple/General/python-openeo/openeo-api/0.0.4

so feel free to stop supporting 0.3, and start with cleaning code where needed.

@m-mohr
Copy link
Member

m-mohr commented Aug 20, 2019

Aha, I thought there were none because I couldn't fine them on PyPI.

soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Sep 5, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Sep 5, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Sep 11, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Sep 12, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Sep 13, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Sep 16, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Oct 17, 2019
- cross-check check and streamline test_rastercube unit tests in the process
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Oct 17, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Oct 17, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Oct 17, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Oct 24, 2019
- cross-check check and streamline test_rastercube unit tests in the process
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Oct 24, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Oct 24, 2019
soxofaan added a commit that referenced this issue Oct 25, 2019
- cross-check check and streamline test_rastercube unit tests in the process
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Nov 18, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Nov 18, 2019
soxofaan added a commit that referenced this issue Nov 18, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Nov 21, 2019
soxofaan added a commit that referenced this issue Nov 21, 2019
and remove `download` from `ImageCollection` base class.
Also drop pre-0.4 support from download (issue #72)
@jdries
Copy link
Collaborator

jdries commented Nov 30, 2019

Could no longer find major pre 0.4.0 pieces of code, so considering this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants