Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing daterange and bbox filter methods on ImageCollection classes #67

Closed
soxofaan opened this issue Jul 18, 2019 · 1 comment
Closed

Confusing daterange and bbox filter methods on ImageCollection classes #67

soxofaan opened this issue Jul 18, 2019 · 1 comment
Assignees
@soxofaan

Comments

@soxofaan
Copy link
Member

Base class ImageCollection (in openeo.imagecollection)

  • defines date_range_filter(self, start_date,end_date)
    • not implemented (just pass)
    • flagged in docblock as deprecated (use filter_daterange instead)
  • defines filter_daterange(self, extent)
    • implemented basically by calling date_range_filter()

Child classes (ImageCollectionClient in openeo.rest and GeotrellisTimeSeriesImageCollection in GeoPyspark driver):

  • override date_range_filter(self, start_date,end_date) with actual implementation
  • no def of filter_daterange(self, extent)

Same pattern for bbox_filter and filter_bbox

So the deprecated methods are implemented and the new non-deprecated calls forward to deprecated implementations? Shouldn't it be the other way around?
@soxofaan soxofaan self-assigned this Jul 18, 2019
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
Issue Open-EO#67: add filter_temporal and deprecate the old version…
c456af0 
…s better

- add `ImageCollection.filter_temporal` (name closer to 0.4,x spec)
- allow more call patterns: without kwargs, with `start_date`/`end_date`, with `extent`
- add deprecate decoration to old variations `date_range_filter` and `filter_daterange`
- simplify API (`_filter_temporal`) that subclasses have to implement
- make sure old-style subclasses keep working
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
fixup! Issue Open-EO#67: add filter_temporal and deprecate the old …
a7259bf 
…versions better
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
fixup! fixup! Issue Open-EO#67: add filter_temporal and deprecate t…
03d0698 
…he old versions better
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
fixup! fixup! fixup! Issue Open-EO#67: add filter_temporal and depr…
2783ddc 
…ecate the old versions better
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
Issue Open-EO#67: make filter_bbox the main method and deprecated `…
c804a9a 
…bbox_flter` more
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
fixup! Issue Open-EO#67: make filter_bbox the main method and depre…
fadb94f 
…cated `bbox_flter` more
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
fixup! fixup! Issue Open-EO#67: make filter_bbox the main method an…
6a60a5e 
…d deprecated `bbox_flter` more
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
fixup! Issue Open-EO#67: add filter_temporal and deprecate the old …
41e7033 
…versions better
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
Issue Open-EO#67: add filter_temporal and deprecate the old version…
3d58b57 
…s better

- add `ImageCollection.filter_temporal` (name closer to 0.4,x spec)
- allow more call patterns: without kwargs, with `start_date`/`end_date`, with `extent`
- add deprecate decoration to old variations `date_range_filter` and `filter_daterange`
- simplify API (`_filter_temporal`) that subclasses have to implement
- make sure old-style subclasses keep working
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
Issue Open-EO#67: make filter_bbox the main method and deprecated `…
7a9e9d1 
…bbox_filter` more
@soxofaan soxofaan mentioned this issue Jul 19, 2019
Merged
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
Issue Open-EO#67: make filter_bbox the main method and deprecated `…
a91a386 
…bbox_filter` more
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Jul 19, 2019
@soxofaan
Issue Open-EO#67 improve date (object) handling in filter_temporarl
e8d982a 
Make sure that date/datetime objects passed to `filter_temporal` function are properly converted to strings in the process graphs
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Aug 5, 2019
@soxofaan
Issue Open-EO#67: add filter_temporal and deprecate the old version…
57a60d9 
…s better

- add `ImageCollection.filter_temporal` (name closer to 0.4,x spec)
- allow more call patterns: without kwargs, with `start_date`/`end_date`, with `extent`
- add deprecate decoration to old variations `date_range_filter` and `filter_daterange`
- simplify API (`_filter_temporal`) that subclasses have to implement
- make sure old-style subclasses keep working
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Aug 5, 2019
@soxofaan
Issue Open-EO#67: make filter_bbox the main method and deprecated `…
6c6abcb 
…bbox_filter` more
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Aug 5, 2019
@soxofaan
Issue Open-EO#67 improve date (object) handling in filter_temporal
c5c035f 
Make sure that date/datetime objects passed to `filter_temporal` function are properly converted to strings in the process graphs
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Aug 26, 2019
@soxofaan
Issue Open-EO#67: add filter_temporal and deprecate the old version…
fd4d1f8 
…s better

- add `ImageCollection.filter_temporal` (name closer to 0.4,x spec)
- allow more call patterns: without kwargs, with `start_date`/`end_date`, with `extent`
- add deprecate decoration to old variations `date_range_filter` and `filter_daterange`
- simplify API (`_filter_temporal`) that subclasses have to implement
- make sure old-style subclasses keep working
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Aug 26, 2019
@soxofaan
Issue Open-EO#67: make filter_bbox the main method and deprecated `…
24c6896 
…bbox_filter` more
soxofaan added a commit to soxofaan/openeo-python-client that referenced this issue Aug 26, 2019
@soxofaan
Issue Open-EO#67 improve date (object) handling in filter_temporal
06f07c5 
Make sure that date/datetime objects passed to `filter_temporal` function are properly converted to strings in the process graphs
@soxofaan
Copy link
Member Author

soxofaan commented Sep 4, 2019

issue resolved by #69

@soxofaan soxofaan closed this as completed Sep 4, 2019
soxofaan added a commit to Open-EO/openeo-geopyspark-driver that referenced this issue Sep 6, 2019
@soxofaan
eliminate deprecated bbox_filter method (Issue Open-EO/openeo-pytho…
2b6e1f7 
…n-client#67)
@soxofaan soxofaan mentioned this issue Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soxofaan soxofaan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soxofaan