-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improvement spectral indices functions #501
Comments
Already did a first couple of improvements:
|
Now also added a new argument
|
As mentioned in #485 I now also added option to manually specify the band mapping. See documentation at https://open-eo.github.io/openeo-python-client/cookbook/spectral_indices.html#band-mapping (these features are not released yet, will be for next release 0.26.0 FYI) I think this resolves the most important issues raised here:
done
done
done
done
Note done yet, I will make a separate ticket for that -> #507
done for indices that were being overwritten. Completely getting rid of extra-indices-dict.json is for #506 |
The spectral indices functions in openEO show some important shortcoming to be production ready. There have to be several fixed implemented:
==> also do not forget to implement issue Extend applicability of "awesome spectral indices" wrapper beyond pure
load_collection
data #485moreover issues that the Sentinel2 bands are not correctly defines in the code is then also obsolete.... e.g. B8A is named N2 in the awesome package and NOT RE4 as in the openEO
see BAND_MAPPING_SENTINEL2 = {
"B1": "A",
"B2": "B",
"B3": "G",
"B4": "R",
"B5": "RE1",
"B6": "RE2",
"B7": "RE3",
"B8": "N",
"B8A": "RE4",
"B9": "WV",
"B11": "S1",
"B12": "S2",
}
some of the VI's defines in the awsome package need CONSTANTS --> these have to be added to the approach and should be loaded from [constants.json] !!!
Note: the CONSTANT lambdaG, lambddaN and lambdaR have to be filled by the specification of the sensor (center wavelength of the band of the used satellite)
the usage of the extra-indices-dict.json in the load_indices() function must be checked..... currently some indices are overwritten which have the same name but in the awesome package a complete different definition. That is a nogo! If additional VI wants to be added then make sure they have a clear new name and not overlapping with the awesome package definitions.
The text was updated successfully, but these errors were encountered: