Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass basemap details (url, attribution) to Vue components via env vars? #260

Closed
m-mohr opened this issue Dec 15, 2021 · 1 comment
Closed
Assignees

Comments

@m-mohr
Copy link
Member

m-mohr commented Dec 15, 2021

As the Python client is relying on the open-source Vue Components the mapping is still done through OpenStreetMap. For openEO Platform, we could maybe implement something that sets the basemap (here: Mapbox) config in the Python client for the Vue Components based on some environment variables that we set globally in the JupyterLab environment, but not sure about that.

We need to pass two options at least:

  • Attribution: OPENEO_VUE_BASEMAP_ATTRIBUTION -> © <a href="https://www.mapbox.com/about/maps/">Mapbox</a> © <a href="http://www.openstreetmap.org/copyright">OpenStreetMap</a> <strong><a href="https://www.mapbox.com/map-feedback/" target="_blank">Improve this map</a></strong>
  • URL: OPENEO_VUE_BASEMAP_URL -> https://api.mapbox.com/styles/v1/mapbox/light-v10/tiles/{z}/{x}/{y}?access_token=...
@soxofaan
Copy link
Member

soxofaan commented Jan 6, 2022

#261 added support for env vars

  • OPENEO_BASEMAP_URL
  • OPENEO_BASEMAP_ATTRIBUTION

@soxofaan soxofaan closed this as completed Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants