-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change logging structure #128
Conversation
Codecov Report
@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 77.84% 76.63% -1.21%
==========================================
Files 25 25
Lines 1020 1070 +50
==========================================
+ Hits 794 820 +26
- Misses 226 250 +24
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
As mentioned above: a library should never initialize loggers, especially not during/before imports. That's the responsibility of an application or entrypoint script.
That's one of the reasons it should not be done magically by a library: to give the user/application the proper opportunity to set up the logging as desired. |
Co-authored-by: Stefaan Lippens <[email protected]>
Follow-up to conversation in Open-EO/openeo-python-client#434 (comment)
@clausmichele what do you think about this structure instead?