Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make band filtering more consistent #29

Closed
soxofaan opened this issue Nov 5, 2019 · 3 comments
Closed

Make band filtering more consistent #29

soxofaan opened this issue Nov 5, 2019 · 3 comments

Comments

@soxofaan
Copy link
Member

soxofaan commented Nov 5, 2019

Implementation of band filtering and handling is confusing at the moment

in GeoPySparkLayerCatalog.load_collection:

  • s3_jp2_pyramid, file_pyramid, and some others do handle band filtering immediately, while accumulo_pyramid and s3_pyramid do not
  • at the end there is an additional image_collection.band_filter(band_indices), which will probably fail for the cases where band filtering already happened

in GeotrellisTimeSeriesImageCollection:

  • there is some stuff going on with _band_index which only considers the first band of the list, this is probably a temp hack that has to be eliminated
  • band_filter does a special case for source type "file", but that is probably not correct anymore (now that that there are multiple source types that handle band filtering up front)
soxofaan added a commit that referenced this issue Nov 5, 2019
@soxofaan
Temporary workaround for double band filtering issue in load_collecti…
2e7bdfa 
…on (#28, #29)

related to issue #28
needs a more in-depth solution: see #29
@jdries
Copy link
Contributor

jdries commented Jun 22, 2020 •
edited
Loading

In GeotrellisTimeSeriesImageCollection:

  • _band_index got removed, now see what tests tell us
  • band_filter no longer has a special case

jdries added a commit that referenced this issue Jun 23, 2020
@jdries
EP-3131 #29 no special treatment for 'file' data source in band_filter
31c6276
jdries added a commit that referenced this issue Jun 23, 2020
@jdries
EP-3131 #29 remove 'still_needs_band_filter', each pyramid factory ha…
c315d38 
…s to filter on bands itself
@jdries
Copy link
Contributor

jdries commented Jun 23, 2020

Also cleaned up layercatalog a bit. The idea is now that the pyramidFactories are responsible for applying the band filter directly.

@jdries jdries closed this as completed Jun 23, 2020
jdries added a commit that referenced this issue Jun 24, 2020
@jdries
EP-3131 #29 restore band filtering, was a bit too fast!
e148fcc
@soxofaan
Copy link
Member Author

great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soxofaan @jdries