add TODOs

Open-EO/openeo-geotrellis-extensions#317
Open-EO · Oct 11, 2024 · 4cbd4a1 · 4cbd4a1
1 parent a08da1b
commit 4cbd4a1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/openeogeotrellis/integrations/tiffset.py b/openeogeotrellis/integrations/tiffset.py
@@ -11,4 +11,5 @@ def embed_gdal_metadata(gdal_metadata_xml: str, geotiff_path: Union[Path, str]):
         tmp.write(f"{gdal_metadata_xml}\n")
         tmp.flush()
 
+        # TODO: print stdout/stderr in case of error
         subprocess.check_call(["tiffset", "-sf", "42112", tmp.name, str(geotiff_path)])
diff --git a/tests/datacube_fixtures.py b/tests/datacube_fixtures.py
@@ -7,6 +7,8 @@
 
 from openeogeotrellis.service_registry import InMemoryServiceRegistry
 
+# TODO: put these things in a function that accepts a tile_size parameter to avoid having to change a lot of tests,
+#  then request tile_size=16 for tests that actually write GeoTiffs
 TILE_SIZE = 16
 
 matrix_of_one = np.zeros((1, TILE_SIZE, TILE_SIZE))