Add Remote UDP extension #515 #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
Jun 27, 2024
m-mohr
commented
Jun 27, 2024
m-mohr
commented
Jun 27, 2024
m-mohr
commented
Jun 27, 2024
soxofaan
reviewed
Jun 28, 2024
Co-authored-by: Stefaan Lippens <[email protected]>
soxofaan
reviewed
Jul 1, 2024
|
|
||
| ### Error Handling | ||
|
|
||
| The following error SHOULD be reported if the namespace can't be resolved: |
There was a problem hiding this comment.
What if the URL can be resolved, but the document does not fit? e.g. it's not JSON, it does not follow expected schema, it doesn't contain a process_graph property, ...?
Shouldn't this also be a ProcessNamespaceInvalid?
Or would that be for standard errors like ProcessInvalid, ProcessGraphMissing? Note however that these don't have placeholders like for a reason, so that could lead to poor error messages
There was a problem hiding this comment.
Yeah, I guess that should fallback to the standard errors. Generally, back-ends can also define own error messages and codes. If specific common cases occur that are not covered and need a reason, we can fine-tune this later. Please give feedback :-)
This was referenced Jul 1, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an extension to enable loading user-defined processes that are hosted externally through the process namespace into process graphs.
Closes #515