Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to packchk to fail if warning/info violations are detected #886 (#583) #948

Merged
merged 1 commit into from
May 31, 2023

Conversation

grasci-arm
Copy link
Collaborator

added:

  • option "--pedantic" (as bool), where packchk returns 1 on WARNINGs
  • prepared for "--pedantic [warning|info]", this would touch ErrLog library

…pen-CMSIS-Pack#886 (Open-CMSIS-Pack#583)

added:
- option "--pedantic" (as bool), where packchk returns 1 on WARNINGs
- prepared for "--pedantic [warning|info]", this would touch ErrLog library
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #948 (9b42210) into main (200189a) will decrease coverage by 0.03%.
The diff coverage is 28.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
- Coverage   53.89%   53.87%   -0.03%     
==========================================
  Files         116      116              
  Lines       22339    22359      +20     
  Branches    12359    12367       +8     
==========================================
+ Hits        12040    12045       +5     
- Misses       8188     8201      +13     
- Partials     2111     2113       +2     
Flag Coverage Δ
packchk-cov 60.71% <28.57%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tools/packchk/src/ParseOptions.cpp 57.89% <10.00%> (-3.90%) ⬇️
tools/packchk/src/PackChk.cpp 65.65% <25.00%> (-1.72%) ⬇️
tools/packchk/src/PackOptions.cpp 58.46% <57.14%> (-0.27%) ⬇️

@github-actions
Copy link

Test Results

    6 files    12 suites   4s ⏱️
  34 tests   34 ✔️ 0 💤 0
102 runs  102 ✔️ 0 💤 0

Results for commit 9b42210.

@edriouk edriouk merged commit 5c7206a into Open-CMSIS-Pack:main May 31, 2023
@edriouk edriouk deleted the outbound/packchk#886 branch May 31, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants