[csolution/packchk] 'name' attribute specifying folder in pack with file element causes segmentation fault. #657 (#482) #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile element causes segmentation fault. Open-CMSIS-Pack#657 (Open-CMSIS-Pack#482) * [csolution/packchk] 'name' attribute specifying folder in pack with file element causes segmentation fault. Open-CMSIS-Pack#657 Open-CMSIS-Pack#657 - added: check all <file> but category="include" against IsDirectory() - removed file check filter for some of the known types, as <file> can be one of file table: https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/main/html/pdsc_components_pg.html#FileCategoryEnum - added test case for new message M356 ("Path '%PATH%' does not specify a file!")
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 51.46% 51.47%
=======================================
Files 116 116
Lines 21543 21544 +1
Branches 11872 11874 +2
=======================================
+ Hits 11087 11089 +2
Misses 8442 8442
+ Partials 2014 2013 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JonatanAntoni
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#657
https://open-cmsis-pack.github.io/Open-CMSIS-Pack-Spec/main/html/pdsc_components_pg.html#FileCategoryEnum