Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackChk: issue on relative paths during case-sense check (#452) #707

Merged

Conversation

grasci-arm
Copy link
Collaborator

@grasci-arm grasci-arm commented Jan 31, 2023

PackChk: issue on relative paths during case-sense check
excluding files from case sense check that have relative path elements "./" or "../"
added test if files are above pack root directory
– added test

Co-authored-by: Thorsten de Buhr [email protected]
#75

@JonatanAntoni JonatanAntoni self-requested a review January 31, 2023 15:22
JonatanAntoni
JonatanAntoni previously approved these changes Jan 31, 2023
@github-actions
Copy link

github-actions bot commented Jan 31, 2023

Test Results

    8 files    16 suites   6s ⏱️
  26 tests   26 ✔️ 0 💤 0
104 runs  104 ✔️ 0 💤 0

Results for commit ef31177.

♻️ This comment has been updated with latest results.

@JonatanAntoni JonatanAntoni self-requested a review January 31, 2023 15:52
JonatanAntoni
JonatanAntoni previously approved these changes Jan 31, 2023
excluding files from case sense check that have relative path elements "./" or "../"
added test if files are below pack root directory

Co-authored-by: Thorsten de Buhr <[email protected]>
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #707 (ef31177) into main (0079238) will decrease coverage by 0.05%.
The diff coverage is 64.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   51.19%   51.15%   -0.05%     
==========================================
  Files         116      116              
  Lines       21361    21378      +17     
  Branches    11738    11747       +9     
==========================================
- Hits        10936    10935       -1     
- Misses       8427     8438      +11     
- Partials     1998     2005       +7     
Flag Coverage Δ
packchk-cov 50.79% <64.70%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tools/packchk/include/CheckFiles.h 100.00% <ø> (ø)
tools/packchk/src/CheckFiles.cpp 46.86% <64.70%> (-2.35%) ⬇️

@JonatanAntoni JonatanAntoni self-requested a review February 7, 2023 08:28
@JonatanAntoni JonatanAntoni merged commit 5abf99f into Open-CMSIS-Pack:main Feb 7, 2023
@JonatanAntoni JonatanAntoni deleted the outbound/SDCMSIS-1711_2 branch February 7, 2023 08:29
@jkrech jkrech linked an issue Feb 7, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PackChk problem with "doc" attribute in the <example> element
2 participants