Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeQL warnings in SVDConv and PackChk #682

Merged

Conversation

grasci-arm
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #682 (58773ba) into main (3cd2f56) will decrease coverage by 0.03%.
The diff coverage is 45.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
- Coverage   50.90%   50.87%   -0.03%     
==========================================
  Files         116      116              
  Lines       21254    21270      +16     
  Branches    11650    11665      +15     
==========================================
+ Hits        10819    10821       +2     
- Misses       8445     8452       +7     
- Partials     1990     1997       +7     
Flag Coverage Δ
packchk-cov 51.07% <0.00%> (ø)
svdconv-cov 32.45% <48.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tools/packchk/include/GatherCompilers.h 100.00% <ø> (ø)
tools/packchk/src/PackOptions.cpp 53.59% <0.00%> (ø)
tools/svdconv/SVDModel/src/SvdDerivedFrom.cpp 56.33% <0.00%> (-1.64%) ⬇️
tools/svdconv/SVDModel/src/SvdEnum.cpp 45.34% <0.00%> (-0.29%) ⬇️
tools/svdconv/SVDModel/src/SvdField.cpp 38.25% <0.00%> (-0.39%) ⬇️
tools/svdconv/SVDModel/src/SvdDimension.cpp 45.67% <45.83%> (-1.01%) ⬇️
tools/svdconv/SVDModel/src/SvdDevice.cpp 49.46% <60.00%> (ø)
tools/svdconv/SVDModel/src/SvdTypes.cpp 46.42% <63.63%> (ø)
tools/svdconv/SVDModel/src/SvdCExpression.cpp 65.11% <70.00%> (+1.55%) ⬆️
tools/svdconv/SVDModel/src/SvdItem.cpp 53.92% <72.22%> (ø)
... and 8 more

@github-actions
Copy link

github-actions bot commented Jan 24, 2023

Test Results

  8 files  16 suites   0s ⏱️
23 tests 23 ✔️ 0 💤 0
92 runs  92 ✔️ 0 💤 0

Results for commit 58773ba.

♻️ This comment has been updated with latest results.

@JonatanAntoni JonatanAntoni self-requested a review January 24, 2023 15:31
@JonatanAntoni JonatanAntoni merged commit 0ec448e into Open-CMSIS-Pack:main Jan 24, 2023
@JonatanAntoni JonatanAntoni deleted the outbound/SDCMSIS-1882 branch January 24, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants