Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix, Recursion Error #369 #404

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Bug fix, Recursion Error #369 #404

merged 5 commits into from
Sep 4, 2024

Conversation

SCMusson
Copy link
Contributor

@SCMusson SCMusson commented Aug 23, 2024 •
edited by nielstron
Loading

Targeting #369

TODO:

  • implement gt and lt binops for booleans
  • implement adding bools and ints
  • Write unit tests

@SCMusson SCMusson changed the base branch from main to dev August 23, 2024 22:14
nielstron
nielstron reviewed Sep 4, 2024
View reviewed changes
opshin/tests/test_misc.py Outdated Show resolved Hide resolved
nielstron
nielstron reviewed Sep 4, 2024
View reviewed changes
opshin/tests/test_misc.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 4, 2024 •
edited
Loading

Coverage Status

coverage: 89.406% (+0.03%) from 89.376%
when pulling 8df47f1 on SCMusson:bug_fix_bool_to_int
into fd297fb on OpShin:dev.

@nielstron
Copy link
Contributor

Looks good, thank you @SCMusson
Please send your Cardano Mainnet Address so that I can transfer the bug bounty!

@nielstron nielstron merged commit 6f99124 into OpShin:dev Sep 4, 2024
8 checks passed
@SCMusson
Copy link
Contributor Author

SCMusson commented Sep 4, 2024

addr1qxuyxgyx9qak0nw2pd8wukvy2vdkmgfmr49jkca8ex5nhf493vtsr3yl4f3553sxfx7wzx58cx5pnhekvtlgqf55lw9s3nt0ty

@nielstron
Copy link
Contributor

Bounty paid out in e65c681eeadff8283afa7e00c84cb3c3beb6db1db671f0fe57f8e885df956454 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielstron nielstron nielstron left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SCMusson @coveralls @nielstron