Add bytes.fromhex #393
Merged
Add bytes.fromhex #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
Comment on lines
+433
to
+440
| try: | ||
| ret = eval_uplc_value(source_code, i.encode("utf8")) | ||
| except RuntimeError as e: | ||
| ret = None | ||
| try: | ||
| exp = bytes.fromhex(i) | ||
| except ValueError: | ||
| exp = None |
There was a problem hiding this comment.
The nested try-except blocks for eval_uplc_value and bytes.fromhex can make the code harder to read and maintain. If both operations are expected to fail under similar conditions, consider combining the error handling to simplify the logic.
Recommended Solution:
Combine the try-except blocks to handle both operations together, improving readability and maintainability.
|
Payment was issued to $nielstron in this transaction: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #103 and currently works using the object like this
Another implementation (using
bytes.fromhex) will not be available without also adding #365 .