New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend assert sum example and ensure determinism among union types #285

Merged

nielstron merged 3 commits into dev from fix/determinism_union_types

Nov 1, 2023

Contributor

nielstron commented Nov 1, 2023 •

edited

Loading

This removes all sources of non-determinism by replacing usages of set with OrderedSet.

Note that dictionaries are guaranteed to preserve insertion order upon iteration as of python 3.7+.

@ross-spencer feel free to try and break this fix :)

TODO

include other compilations in the testing for deterministic compilation (i.e. parameterized)
optionally write pre-commit script that warns of usage of set

nielstron added 2 commits

November 1, 2023 10:54


          Extend assert sum example and ensure determinism among union types

f9d76d1


          Extend the scope of determinism check

50441be

Contributor Author

nielstron commented Nov 1, 2023

again, this should fix #282


          Bump pluthon version, which uses ordered-set itself

f0402bb

nielstron merged commit 6738356 into dev

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet