Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement fractions with class methods i.e. __add__ and __mul__ etc #395

Closed
nielstron opened this issue Jul 31, 2024 · 1 comment
Closed

Implement fractions with class methods i.e. __add__ and __mul__ etc #395

nielstron opened this issue Jul 31, 2024 · 1 comment
Labels
bb: minor Minor issue according to bug bounty categorization bug bounty This issue is prized out as part of the Bug Bounty Program enhancement New feature or request

Comments

@nielstron
Copy link
Contributor

nielstron commented Jul 31, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, fraction handling is very tedious, requiring specialized functions like frac_mul(x, y) to multiply fractions.

Describe the solution you'd like
Since #366 was resolved, it is now possible to implement dunder methods for the Fractions class in the fractions std lib - this would allow overwriting the behavior of i.e. __add__ s.t. x + y is valid when x and y are Fractions.

Describe alternatives you've considered
None

Additional context
None

Bug bounty: 300 ADA
@nielstron nielstron added enhancement New feature or request bb: minor Minor issue according to bug bounty categorization bug bounty This issue is prized out as part of the Bug Bounty Program labels Aug 21, 2024
@SCMusson
Copy link
Contributor

I'll claim this one

@SCMusson SCMusson mentioned this issue Aug 23, 2024
Merged
nielstron added a commit that referenced this issue Oct 8, 2024
@nielstron
Merge pull request #403 from SCMusson/feat_frac_dunder
26f7532 
Fractions functionality issue #395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bb: minor Minor issue according to bug bounty categorization bug bounty This issue is prized out as part of the Bug Bounty Program enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nielstron @SCMusson