multiple new collateral pricefeeds #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanga128
reviewed
Mar 27, 2023
|
|
||
| import "contracts/feeds/IPriceFeedsExt.sol"; | ||
|
|
||
| contract ATokenPriceHelper_ARB is IPriceFeedHelper { |
There was a problem hiding this comment.
maybe we could use mapping and few configuration transactions instead of hardcode all these addresses
There was a problem hiding this comment.
mapping is going to be more expensive to use
contracts/feeds/pricehelpers/arbitrum/ITokenPriceFeedHelperV2_ARB.sol
Outdated
Show resolved
Hide resolved
contracts/feeds/pricehelpers/arbitrum/ITokenPriceFeedHelperV2_ARB.sol
Outdated
Show resolved
Hide resolved
Drypto13
reviewed
Mar 27, 2023
| IAToken private constant aArbWETH = IAToken(0xe50fA9b3c56FfB159cB0FCA61F5c9D750e8128c8); | ||
|
|
||
| address private constant DAI = 0xDA10009cBd5D07dd0CeCc66161FC93D7c9000da1; | ||
| address private constant ERUS = 0xD22a58f79e9481D1a88e00c343885A588b34b68B; |
Drypto13
reviewed
Mar 27, 2023
| function latestAnswer(address token) external view returns (uint256) { | ||
| require(token == CURVE_USDT_USDC_TOKEN, "unsupported"); | ||
| uint256 balanceUSD = USDT.balanceOf(CURVE_USDT_USDC_TOKEN) * uint256(USDT_PRICE_FEED.latestAnswer()) / 1e8; | ||
| balanceUSD += USDC.balanceOf(CURVE_USDT_USDC_TOKEN) * uint256(USDC_PRICE_FEED.latestAnswer()) / 1e8; |
There was a problem hiding this comment.
Would be better to value by using the virtual price and using the lowest priced token, whether that is USDT or USDC to value the virtual price
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.