Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staking Vault #291

Open
wants to merge 26 commits into
base: permissionless-listings
Choose a base branch
from
Open

Staking Vault #291

wants to merge 26 commits into from

Conversation

Drypto13
Copy link
Contributor

No description provided.

@Drypto13 Drypto13 marked this pull request as ready for review December 11, 2022 05:53
@Drypto13 Drypto13 requested review from 0xosama and yanga128 January 12, 2023 04:24
@0xosama 0xosama requested review from yanga128 and removed request for yanga128 February 20, 2023 13:53
0xosama
0xosama reviewed Feb 20, 2023
View reviewed changes
contracts/staking-vault/StakingVault.sol
import "../proxies/0_8/Upgradeable_0_8.sol";
import "../../interfaces/IStakingVault.sol";

contract StakingVault is IStakingVault, Upgradeable_0_8, ERC1155 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to make a way for the guardian to pause functions from this contract preferably protocol should continue to work afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xosama 0xosama 0xosama left review comments

@yanga128 yanga128 Awaiting requested review from yanga128

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drypto13 @0xosama