Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to misc. location hints #2348

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented Jan 14, 2025

  • The names for misc. location hint locations are changed for consistency with the item locations hinted on them. For example, “10 Skulltulas Reward Hint” is renamed to “Kak 10 Gold Skulltula Reward Hint”. This shouldn't break plandos because these aren't item locations.
  • The feature allowing hint distributions to customize the locations hinted on misc. location hints is removed, as it was never implemented properly: the hint text was not adjusted to account for the changed locations, leading to misleading text, and the “already hinted” system always assumed the default location. The alternative of making the customization work properly runs into issues with making arbitrary hint text fit into the various text boxes, so I don't think it's feasible to implement.
  • The logic for the “ZR Frogs Ocarina Game Hint” location (previously called “ZR Frogs Ocarina Minigame Hint”) is fixed to require access as child.
  • The misc. hints for unique merchant locations are incorporated into the misc. location hint system. This prevents them from being shuffled when text is “Shuffled except Important Text”, and marks them as “already hinted”, preventing gossip stones from giving hints that are made redundant by them. This part of the PR is based on Attempt to fix unique merchants not being proper "hint" types #2170, special thanks to @flagrama for calling attention to these bugs and writing the initial fix.

@fenhl fenhl added Type: Bug Something isn't working Type: Enhancement New feature or request Status: Needs Review Someone should be looking at it Component: Hints related to how we help the player Status: Needs Testing Probably should be tested Component: Patching Affects the patching of the ROM labels Jan 14, 2025
@r0bd0g
Copy link

r0bd0g commented Jan 14, 2025

I usually put non-locations like drops/hints and things toward the bottom of location list in any given region. There's absolutely no reason for this (I guess helps to tell real checks from the fake ones) but now that we've got two people arbitrarily moving the location orders around we're gonna end up in an edit war lol.

@r0bd0g
Copy link

r0bd0g commented Jan 14, 2025

I'm curious what setting the frogs hint to is_child actually does. Like, does it free the location up to be hinted if it turns out that child can't access the river, is that what it does?

@fenhl
Copy link
Collaborator Author

fenhl commented Jan 14, 2025

I usually put non-locations like drops/hints and things toward the bottom of location list in any given region. There's absolutely no reason for this (I guess helps to tell real checks from the fake ones) but now that we've got two people arbitrarily moving the location orders around we're gonna end up in an edit war lol.

I moved them to be paired like this because they are closely related, and so you more easily understand how their access requirements relate.

I'm curious what setting the frogs hint to is_child actually does. Like, does it free the location up to be hinted if it turns out that child can't access the river, is that what it does?

Yeah, I guess that's the only actual implication here. I mostly just fixed it because the current logic doesn't match the actual in-game access requirements, and all the other ones have their actual access requirements rather than just True, so I believe this was an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hints related to how we help the player Component: Patching Affects the patching of the ROM Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants