Implementation of 100 Skulltula Check

[Jaybone25]

PR Contains the implementation of a 100 Gold Skulltula check.

In this PR I have also taken the liberty of moving the Skulltula Misc hints out of hacks.asm and into /Hacks/ovl_en_ssh.asm to clean up the hacks file, and added the code for the 100 Skulltula Misc hint in this file as well.

Current implementation has it as a default check, if desired, I can make it a setting, however it didn't feel correct to make something a setting that can just be excluded on another tab.

Since this would potentially affect current presets, I have went through and disabled the check in all presets except Hell Mode, as it felt appropriate to keep it in there.

[fenhl]

I feel like this should be a setting. It's normally a repeatable item which isn't typically something included in the basic set of shuffled locations. It also follows precedent set by frog shuffle being a setting even though it works much more like a regular check.

[Jaybone25]

That's fine. I can do this. I just expected leaving it as default would be the preferred way since you can just disable checks form the excluded checks area so this as a setting kind of has the same function as that.

I'll expand the setting then to make it a list of which skull checks to turn on then, so that you can turn off any of the skull checks from there rather than just the 100.

[fenhl]

I don't think expanding the setting makes sense, since that would be redundant with excluding locations, and the other skull checks already exist so the frog shuffle precedent doesn't apply.

[Jaybone25]

Sounds good

[cjohnson57]

Agree with Fenhl, since it's a non-standard location type it should be a setting

[Jaybone25]

Sounds good.  I wasn’t 100% sure what that code was doing, but I’ll make it conditional, as well as fix the error with the CI checks.  Sent from my iPhoneOn Nov 5, 2024, at 12:22 AM, Fenhl ***@***.***> wrote: @fenhl requested changes on this pull request. In World.py:

@@ -267,7 +267,7 @@ def __missing__(self, dungeon_name: str) -> EmptyDungeonInfo:

max_tokens = max(max_tokens, self.settings.lacs_tokens) if self.settings.shuffle_ganon_bosskey == 'tokens': max_tokens = max(max_tokens, self.settings.ganon_bosskey_tokens) - tokens = [50, 40, 30, 20, 10] + tokens = [100, 50, 40, 30, 20, 10] 100 should be conditionally added to this list based on the setting. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>

[fenhl]

With 100 skulls being included in Hell Mode, Gbk should probably be changed to 20 hearts to have those required as well.

[r0bd0g]

Nothing about having this check shuffled actually forces 100 gs to be collected every time though?

[Jaybone25]

Thx should be fixed as soon as the tests go through.

[fenhl]

Nothing about having this check shuffled actually forces 100 gs to be collected every time though?

Right, but now there's a check which can potentially require the tokens, which isn't the case for the hearts.

[r0bd0g]

It's not super likely that something required goes on 100. I think 100 wincon is still worse just b/c there's so many more of them.

[cjohnson57]

It's not super likely that something required goes on 100. I think 100 wincon is still worse just b/c there's so many more of them.

I agree with this after giving it some thought. 100GS bridge should still be a higher number of required checks, on average

[fenhl]

Yeah, that's fair.

[Jaybone25]

Agreed.  I just made it mostly cause you can do some plando stuff with it and I’ve seen it requested before.  You could def get some keys/bks there but not a ton else.Sent from my iPhoneOn Dec 6, 2024, at 1:24 AM, Fenhl ***@***.***> wrote: Yeah, that's fair. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>