Move cutscenes skips out of Patches.py, improve documentation, add a new one and improve on two existing ones #2219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to start on #2213
This PR moves all cutscenes skips done in Patches.py to a new file Cutscenes.py, and tries to document them by interfacing some of the hacks done with clearer functions, or by adding comments on their purpose. Most of them have been cleaned of unnecessary byte changes, which are a ton easier to detect nowadays with decomp.
The hacks have been sorted by "Vanilla walkthrough" order.
There's also a couple of additions :
New cutscene shortened :
Already existing cutscenes skips shortened further
These two cutscenes waited for their respective flags to be set before being cut. With the new functions we can easily set the flag on the first frame and then immediately stop.
Aside from that, the behaviour to all cutscenes should be strictly identical to before and if not then i made a mistake somewhere !
They were all left untouched because the purpose of this change was not so much to improve on existing skips rather than making them easier to either improve or toggling them off in future devs.