Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup the other three Steal Epona cutscenes #2212

Merged
merged 1 commit into from
May 6, 2024
Merged

Speedup the other three Steal Epona cutscenes #2212

merged 1 commit into from
May 6, 2024

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented May 6, 2024 •
edited
Loading

Fixes #1254
The cutscenes after stealing Epona from ranch are now all shortened instead of only the one from jumping the front gate.

epona_escape_west.mp4
epona_escape_east.mp4
epona_escape_south.mp4

@fenhl fenhl added Component: ASM/C Changes some internals of the ASM/C libraries Type: Enhancement New feature or request Status: Needs Review Someone should be looking at it labels May 6, 2024
fenhl
fenhl approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@fenhl fenhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move away from patching raw bytes without explaining what's going on, but that's something that can be done as a separate PR.

@fenhl fenhl removed the Status: Needs Review Someone should be looking at it label May 6, 2024
@fenhl fenhl added this to the next milestone May 6, 2024
@fenhl fenhl merged commit f2980f2 into OoTRandomizer:Dev May 6, 2024
3 checks passed
@fenhl fenhl mentioned this pull request May 6, 2024
Closed
@GSKirox GSKirox deleted the steal_epona_speedup branch May 22, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenhl fenhl fenhl approved these changes

Assignees
No one assigned
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Type: Enhancement New feature or request
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.

Winning Epona Cutscenes not shortened
2 participants
@GSKirox @fenhl